search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Do not install ctags in the vignette if it's already there #90

Closed maelle closed 3 years ago

maelle commented 3 years ago

https://github.com/ropensci-review-tools/pkgcheck/blob/27036396ec317b544205ca03c5f35359c08692dc/vignettes/extending-checks.Rmd#L29

maelle commented 3 years ago

For the rare case when one is building the website locally :wink:

mpadge commented 3 years ago

Wow, you're quick! It should be all okay, and is there as a direct copy of stantargets, as suggested by Jeroen. The ctags_install() function does nothing if either (1) both are already installed, or (2) it's not a unix system. It's there solely for the rOpenSci doc server, which needs it's own independent installation. All okay then?

maelle commented 3 years ago

aaah ok!! can you add this in a comment in the vignette?

I didn't check it took time, I was actually hindered by my having an older pkgstats version locally without the function at all. :sweat_smile:

mpadge commented 3 years ago

BTW have you noticed that calling styler via pre-commit hooks on things like this vignette always fails, which is so annoying I'm thinking of switching it of Screenshot from 2021-10-15 12-08-51

maelle commented 3 years ago

would it fail with normal styler too? is there a way to not use it on vignettes?

mpadge commented 3 years ago

It's related to this issue, for which the fix was fairly simple but only gets switched on if is_plain_r_file, which a .Rmd vignette is not. I'll ping him over there

maelle commented 3 years ago

See also my PR, you had chunks with no new lines.