search

ropensci-review-tools / pkgcheck

Check whether a package is ready for submission to rOpenSci's peer-review system
https://docs.ropensci.org/pkgcheck/
18 stars 6 forks source link

Try making alerts more visible #91

Closed maelle closed 3 years ago

maelle commented 3 years ago

I think the problem was that no "primary" was set.

codecov[bot] commented 3 years ago

Codecov Report

Merging #91 (751e2fa) into main (2703639) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   64.38%   64.38%           
=======================================
  Files          30       30           
  Lines        1881     1881           
=======================================
  Hits         1211     1211           
  Misses        670      670

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2703639...751e2fa. Read the comment docs.

maelle commented 3 years ago

@mpadge now it works but I'm not sure we should use them given the current contrast. I'm also not in favor of adding CSS rules to this repo as we can expect we'll soon switch rotemplate itself to BS4 once BS4 is in the released version of pkgdown. :thinking: