search

ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot
https://docs.ropensci.org/roreviewapi
4 stars 1 forks source link

tryCatch for system dependency installs #19

Closed mpadge closed 3 years ago

mpadge commented 3 years ago

Because that can also fail, like in the initial submission of OmicsMetaData (issue 471), corresponding to this point in the repo history, in which the DESCRIPTION file had minimal versions of every package formatting with (<=X.X.X). The lack of space after <= causes an error in remotes::install_deps(). That should be controlled and a meaningful message returned instead.

mpadge commented 3 years ago

Note that the above commit reverts back to prior state by removing tryCatch. Both the system and R-dependency installation procedures can generate minor errors along the way, yet proceed regardless. A tryCatch can then unnecessarily stop the entire process, so it has been removed. This may lead to some rcmdcheck results indicating "packages required but not installed", which may then have to be manually de-bugged.

mpadge commented 3 years ago

Re-opening to change so that information on any packages unable to be installed can be returned to provide more useful information