search

ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot
https://docs.ropensci.org/roreviewapi
4 stars 1 forks source link

Unhelpful 500 fail when package is malformed #21

Closed mpadge closed 3 years ago

mpadge commented 3 years ago

https://github.com/ropenscilabs/statistical-software-review/issues/28#issuecomment-972901749

That's for @maelle 's blabla package which is empty. Should return something more informative.

mpadge commented 3 years ago

Thanks @maelle , that failed because code constructed a data.frame which included OID for latest git commit. When there are no commits, that doesn't exist, and data.frame() fails. That commit fixes so would now return:

[1] "[https://github.com/ropensci/blabla] does not appear to be an R package"

and the bot would dump that as the comment.

mpadge commented 3 years ago

(No rush to redeploy, but next week when it auto-deploys that will be there.)