Temporary fix for r-lib/remotes#663

ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot

https://docs.ropensci.org/roreviewapi

4 stars 1 forks source link

Temporary fix for r-lib/remotes#663 #22

Closed mpadge closed 2 years ago

mpadge commented 2 years ago

https://github.com/r-lib/remotes/issues/663 seems to be affecting the Digital Ocean server, where the failure is entirely reproducible within the server itself, although not directly within the docker container. Work-around will be committed that simply skips installation of system requirements if that error arises and proceeds with the rest. That is clearly going to fail on any packages with sysreqs, but will work otherwise.

If that issue really can not be circumvented, then I''ll need to find another way to install system requirements, which work anyway by just grabbing details directly from the RSPM API as remotes does anyway.

mpadge commented 2 years ago

That commit takes the code directly from remotes but replaces the internal json parser with jsonlite which seems to resolve the issue anyway.

mpadge commented 2 years ago

Nope, it's not yet resolved. The nginx server delivers a "504 Bad Gateway" error when calling RSPM via these lines: https://github.com/ropensci-review-tools/roreviewapi/blob/849b78ed3daf3c944a04f2f9bd709f8d7c14da50/R/dependencies.R#L63-L76

To fix:

[x] Change the curl call cribbed from remotes to httr which is imported here anyway; and
[x] If return code is not 200, fall back to the r-hub database as an alternative