search

ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot
https://docs.ropensci.org/roreviewapi
4 stars 1 forks source link

Change phrasing for `srr_counts` function #32

Closed mpadge closed 2 years ago

mpadge commented 2 years ago

"may proceed to review" or similar

mpadge commented 2 years ago

Not going to implement that, because it's difficult to phrase appropriately. Current statement is "may be submitted." Any alternative can not directly imply that package may simply "proceed to review," because factors other than srr compliance may still prevent that. The statement "may be submitted" is admittedly confusing when check srr is called on a full-submission - because submission has already happened - but other viable kind of alternative statements would be things like "fulfils the requirements of standards compliance," or "complies with a sufficient number of standards to ..." ? To what? ... And statements like that don't really aid clarification anyway. So it'll be left as is for now.