ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot
https://docs.ropensci.org/roreviewapi
4 stars 1 forks source link

Questions about routes #4

Closed sckott closed 3 years ago

sckott commented 3 years ago
mpadge commented 3 years ago

Why do /editorcheck, /goodtoreview, and /stdlogs routes use POST rather than GET? Seems like all information is passed in the query parameters, which suggests GET is more appropriate. But maybe plumber suggests using POST for some reason?

You're right - POST is a hangover from former incarnations that can and should just be GET. I'll change that straight away.

Should some of these routes be not open to the public internet? E.g., do you want to require authentication on /log so that random folks can't see IP addresses, etc.?

Yes indeed! The first point will be addressed straight away, so this issue can remain open for sole purpose of implementing authentication.

sckott commented 3 years ago

Cool, I'll test and report back

sckott commented 3 years ago

Dockerfile needs a fix, will PR

sckott commented 3 years ago

PR opened