ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot
https://docs.ropensci.org/roreviewapi
4 stars 1 forks source link

docs: add ropensci concept to appease pkgdown::check_pkgdown() #42

Closed maelle closed 1 year ago

mpadge commented 1 year ago

I can't even get check_pkgdown() to work at all on my system, so will have to trust you on that one. But isn't there also a missing tag for the previous, readme_badge fn?

maelle commented 1 year ago

is it exported though? pkgdown didn't complain about it

mpadge commented 1 year ago

Yeah, they're all exported (coz they have to be for this pkg to work). check_pkgdown() should definitely fail here, but it doesn't complain for me at all. And yet, when i need it on lots of other packages, it fails even when i know i've done everything right. Grumble grumble ... :bear:

maelle commented 1 year ago

readme_badge is actually listed directly in the config! so good to merge. sorry to hear about the function not working for you, it's so handy :sob: