ropensci-review-tools / roreviewapi

API endpoint for package reviews via ropensci-review-bot
https://docs.ropensci.org/roreviewapi
4 stars 1 forks source link

Catch GitHub "unexpected error" responses #58

Closed mpadge closed 5 months ago

mpadge commented 5 months ago

They arise on https://github.com/ropensci-review-tools/roreviewapi/blob/8ab18b7155a3c0cee4f0d2114874dd1137a26488/R/editor-check.R#L43

and prevent check results from being posted (like here), without issuing any useful diagnostics. These errors need to be caught in that function and appropriate error messages issued.