search

ropensci-review-tools / srr

Software Review Roclets
https://docs.ropensci.org/srr/
Other
5 stars 2 forks source link

Missing standards #33

Closed schneiderpy closed 1 year ago

schneiderpy commented 1 year ago

Hello @mpadge, I have still issues with "missing standards", which are not missing ... On my local machine pkgcheck() indicates no issues with missing standards, however, using checks_to_markdown() which results in a file on my github repository indicate three (3) missing standards: EA.1.0, G1.0, and G1.1. These standards are in the README.rmd file, which I have checked with the srr_report() Any idea? file172433e925d6.knit.pdf

mpadge commented 1 year ago

Thanks again @schneiderpy - that one was also very much a :bug: here, through presuming README files are always exactly and only "README.Rmd", but yours is "README.rmd". Your version is of course also entirely valid, and this helped to make the code more robust to any possible forms of naming "rEaDmE.rMd". Thank you!

mpadge commented 1 year ago

That also made me realise we had not yet added an allcontributors section to this repo - now done, and so publically acknowledging your contribution here.

schneiderpy commented 1 year ago

Thank you @mpadge for pointing this out and finally fixing my incompetence :) pkgcheck() is now passing (after changing .rmd with a new .Rmd file)