search

ropensci-review-tools / srr

Software Review Roclets
https://docs.ropensci.org/srr/
Other
5 stars 2 forks source link

Error in data frame #35

Closed schneiderpy closed 1 year ago

schneiderpy commented 1 year ago

Dear @mpadge

Since my last update/upload of my package "concstats" I encounter this error message from the pkgcheck package (but originated from srr)

Error in data.frame(category = cats$category, std_prefix = cats$prefix, : arguments imply differing number of rows: 9, 8

I have no idea what is wrong or where to look at, since I have not changed any standards.

mpadge commented 1 year ago

@schneiderpy I can't reproduce that, unfortunately. The first things I'd suggest would be to make sure your versions of both pkgcheck and srr are up to date. If you still see the error after updating, then please copy the following code:

library (pkgcheck)
library (srr)
packageVersion("pkgcheck")
packageVersion("srr")
path <- "/<local>/<path>/<to>/concstats"
gert::git_info(path)$commit
s <- srr_report (path)
checks <- pkgcheck (path, goodpractice = FALSE)

Then call reprex::reprex(). If that errors, then please paste the result here. For me it does not error, and gives something like this:

library (pkgcheck)
library (srr)
packageVersion("pkgcheck")
#> [1] '0.1.1.11'
packageVersion("srr")
#> [1] '0.0.1.186'
path <- "/data/mega/code/forks/concstats"
gert::git_info(path)$commit
#> [1] "123d7feba6916a4f9f98a9a8a201dd59b01e75b3"
s <- srr_report (path)
#> ℹ Loading concstats
#> ──────────────────── rOpenSci Statistical Software Standards ───────────────────
#> 
#> 
#> 
#> ── @srrstats standards (914 / 960): 
#> 
#> (lots of srr stuff ....)

checks <- pkgcheck (path, goodpractice = FALSE)
summary (checks)
#> 
#> ── concstats 0.1.4 ─────────────────────────────────────────────────────────────
#> 
#> ✔ Package is already on CRAN.
#> ✔ has a 'codemeta.json' file.
#> ✔ has a 'contributing' file.
#> ✔ uses 'roxygen2'.
#> ✔ 'DESCRIPTION' has a URL field.
#> ✔ 'DESCRIPTION' has a BugReports field.
#> ✔ Package has at least one HTML vignette
#> ✔ All functions have examples.
#> ✔ Package has continuous integration checks.
#> 
#> ℹ Current status:
#> ✔ This package may be submitted.

Created on 2023-02-17 with reprex v2.0.2

schneiderpy commented 1 year ago

@mpadge I paste the end of the srr report ..

-- @srrstatsNA standards (46 / 960):

Selection: 1 Putative code contains lines that start with #>. Are we going in circles? Did you just run reprex(..., venue = "r")? In that case, the clipboard or selection now holds the rendered result. Carry on with this reprex? 1: yes 2: no

s <- srr_report (path)

> Error in srr_report(path): no se pudo encontrar la función "srr_report"

Created on 2023-02-17 by the reprex package (v2.0.1)

Both packages have the latest Version (as indicated in your example). checks <- pkgcheck(path, goodpractice = FALSE) gives the same result as the srr_report summary(checks) doesn't work, because checks is not found

schneiderpy commented 1 year ago

Hello @mpadge here the complete result / output. I reinstalled both packages, but that did't work out ..

library (pkgcheck) library (srr) packageVersion("pkgcheck") [1] ‘0.1.1.11’ packageVersion("srr") [1] ‘0.0.1.181’ path <- "/Users/Acer/Desktop/Analytics/R/myRpackages/concstats" gert::git_info(path)$commit [1] "123d7feba6916a4f9f98a9a8a201dd59b01e75b3" s <- srr_report (path) i Loading concstats -------------------------------------- rOpenSci Statistical Software Standards --------------------------------------

-- @srrstats standards (914 / 960):

-- @srrstatsNA standards (46 / 960):

-- @srrstats standards (914 / 960):

-- @srrstatsNA standards (46 / 960):

mpadge commented 1 year ago

Thanks @schneiderpy. {srr} latest version is 0.0.1.188, but you've got 0.0.1.181. Can you please update that to latest and try again?

schneiderpy commented 1 year ago

Thank you @mpadge .. it was all about "reading" .. the update solved the problem