ropensci / BaseSet

Provides classes for working with sets
https://docs.ropensci.org/BaseSet
Other
10 stars 3 forks source link

rOpenSci reviewer 2: Examples with errors #45

Closed llrs closed 4 years ago

llrs commented 4 years ago

Two examples threw errors:

File: set.R; setMethod("sets<-"

sets(TS) <- data.frame(sets = c("B", "A"))

> Error in validObject(object) :

> invalid class “TidySet” object: All sets must be described on their table.

File: set.R; Function: replace_sets()

TS2 <- replace_sets(TS, data.frame(sets = c("A", "B", "C")))

> Error in validObject(object) :

> invalid class “TidySet” object: All sets must be described on their table.

llrs commented 4 years ago

Not sure, now on R 3.6.3 didn't find that error, but I think I will need to allow for empty TS. Or TidySets with sets but no elements or with elements but no sets.