search

ropensci / BaseSet

Provides classes for working with sets
https://docs.ropensci.org/BaseSet
Other
10 stars 3 forks source link

sets %in% sets #58

Closed llrs closed 1 year ago

llrs commented 2 years ago

There are several cases of sets %in% sets on the length.R file. Not sure if it is a bug, probably it is really isTRUE(all(sets %in% sets)) so it wouldn't matter, but if it is so it can be safely removed. https://github.com/ropensci/BaseSet/blob/4b376bb9ef2071b7e3985b2b4aee0354c84e0a8e/R/length.R#L186

llrs commented 1 year ago

1) there aren't many instances 2) they work to select multiple rows 3) But they could be a problem if they subset a single row and the dimensions are dropped

I added drop = FALSE to all relevant cases.