search

ropensci / EDIutils

An API Client for the Environmental Data Initiative Repository
https://docs.ropensci.org/EDIutils/
Other
10 stars 2 forks source link

Error : 'validate_file_names' is not an exported object from 'namespace:EDIutils' #32

Closed yvanlebras closed 2 years ago

yvanlebras commented 2 years ago

Dear EDIutils team,

using a new test version of MetaShARK, we seen this error message when trying uploading a datafile to "infer" attribute names and related metadata:

Error : 'validate_file_names' is not an exported object from 'namespace:EDIutils'

Can you indicate us if there is an issue with the last version of the R package or maybe an error elsewhere ?

Wishing you a very good end of week !

Cheers,

Yvan

clnsmth commented 2 years ago

Thanks for the notification @yvanlebras. The error you're running into may be related to the recent EDIutils refactor (see here for some context).

There's a good chance this error is arising from a previous release of EMLassemblyline that depended on the now deprecated version of EDIutils. The newest EMLassemblyline doesn't have this dependency and should work with MetaShARK. Try reinstalling EMLassemblyline remotes::install_github("EMLassemblyline") and/or the deprecated EDIutils (remotes::install_github("EDIutils", ref = "deprecated").

I've relayed this information to @earnaud and it sounds a fix on the MetaShARK side is underway.

Please let me know if the issue persists, and my apologies for the inconvenience.

earnaud commented 2 years ago

Hi ! covidded @earnaud is back. I am checking this issue back: in definitive, if EDIutils dependency removed from EMLassemblyline, it shall be ok. Testing right now and ... I still get the error. To be sure: I shall use the current development branch of EAL?

clnsmth commented 2 years ago

Welcome back @earnaud!

I just verified EMLassemblyline (all branches) and MetaShARK (master) do not use EDIutils or the function validate_file_names(), so I'm not sure why this is occurring. Only recommendation I have is to double check the EAL installation and verify EDIutils is not being called from MetaShARK.

earnaud commented 2 years ago

I had MetaShARK built with a dockerfile relying on a newer version of EAL and the issue was gone. Let's just keep it open a few days more if you will, so that @yvanlebras and I can assess it was due to an older version of EAL used in MetaShARK. I appreciate your efficiency for this issue.

clnsmth commented 2 years ago

@earnaud Has this issue been resolved?

earnaud commented 2 years ago

I believe it is, indeed.