search

ropensci / EML

Ecological Metadata Language interface for R: synthesis and integration of heterogenous data
https://docs.ropensci.org/EML
Other
97 stars 33 forks source link

check for factors in set_attributes #211

Closed maelle closed 7 years ago

maelle commented 7 years ago

210

codecov-io commented 7 years ago

Codecov Report

Merging #211 into xml2 will increase coverage by 0.14%. The diff coverage is 100%.

@@            Coverage Diff            @@
##             xml2    #211      +/-   ##
=========================================
+ Coverage   67.25%   67.4%   +0.14%     
=========================================
  Files          24      24              
  Lines        4902    4924      +22     
=========================================
+ Hits         3297    3319      +22     
  Misses       1605    1605
Impacted Files Coverage Δ
R/set_TextType.R 92.68% <100%> (ø) :arrow_up:
R/set_attributes.R 97.1% <100%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16b2315...8ccee9e. Read the comment docs.

maelle commented 7 years ago

@cboettig the test now seems to pass on Windows (locally + Appveyor) 😀

cboettig commented 7 years ago

Nice! Looks like we can merge this and then I'll try and merge xml2 back into master.