search

ropensci / EML

Ecological Metadata Language interface for R: synthesis and integration of heterogenous data
https://docs.ropensci.org/EML
Other
97 stars 33 forks source link

A number of examples in README.md no longer valid #271

Open wetlandscapes opened 5 years ago

wetlandscapes commented 5 years ago

Hi, First, thank you very much for all the hard work you've put into this product. I'm just starting to use the EML package to document my own data. As such I've been looking over the README.md file and notice there are at least a few code examples that seem to no longer work. For example:

attributes <- read.table(system.file("extdata/hf205_attributes.csv", package = "EML")). Looking through the system files associated with the package I see that there is no "extdata" directory, but there is an "examples" directory. Similarly, there is no "hf205_attributes.csv" file.

I think either re-writing the README file, or adding these files back in, would help new users like myself better understand how this code works.

Thanks!

cboettig commented 5 years ago

@wetlandscapes Perhaps you are using the version from CRAN? The README shown here corresponds only to the current version on GitHub, you'll need to do remotes::install_github("ropensci/EML") and possibly restart your R session first.

(If you browse the system files on GitHub, you'll note there is indeed an extdata dir, eg: https://github.com/ropensci/EML/tree/master/inst/extdata). HTH!

wetlandscapes commented 5 years ago

Ah, okay. That explains the large version difference on ropensci/github versus my package list. Maybe it is worth adding the installation line (remotes::install_github("ropensci/EML") to the README?

Thanks for your quick response. I greatly appreciate your efforts!

cboettig commented 5 years ago

good idea!

also we're really overdue for a new CRAN release so stay tuned for that.

mbjones commented 4 years ago

Added to 2.1.0 milestone, but if its already been fixed then just close the issue.