search

ropensci / EML

Ecological Metadata Language interface for R: synthesis and integration of heterogenous data
https://docs.ropensci.org/EML
Other
97 stars 33 forks source link

replace ifelse() with if statement #283

Closed jeanetteclark closed 5 years ago

jeanetteclark commented 5 years ago

When testing on a system that had the error described in issue #278 , this change makes the error go away and the code runs as expected. Still not sure of the root cause of the issue - some setups don't like ifelse for some reason - but this removes the offending function at least

amoeba commented 5 years ago

ifelse requires quite a bit of care to use in package code that takes user input as it isn't type stable and does funny things seemingly more often than not. See https://vctrs.r-lib.org/articles/stability.html#ifelse. So this change is 💯 .