Couple of updates - Githubissues

ropensci / EML

Ecological Metadata Language interface for R: synthesis and integration of heterogenous data

https://docs.ropensci.org/EML

Other

97 stars 33 forks source link

Couple of updates #302

Closed amoeba closed 4 years ago

amoeba commented 4 years ago

See commit messages below...

cboettig commented 4 years ago

@amoeba sorry for slow reply. a few checks look unhappy?

amoeba commented 4 years ago

Ah, right. CHECK is failing because the examples in set_TextType are broken. Need to fix those at some point I guess. Once those examples are removed, the test suite fails because I updated it to match our recent change in emld but testing uses the released version.

cboettig commented 4 years ago

thanks, okay cool, we should probably take care of the emld release (though I suppose we could add a Remotes to DESCRIPTION here to force it to use the dev version meanwhile, especially if this is effecting typical user functions and not just an issue for the test suite...)

Are we still thinking about emld_version() strategy?

amoeba commented 4 years ago

From https://github.com/ropensci/emld/issues/65 it sounds like we should get this merged. Sorry I hadn't gotten back to you on:

Are we still thinking about emld_version() strategy?

I think what we have in place now is good enough, esp. good enough for a release.

cboettig commented 4 years ago

this merge breaks some of the set_TextType examples as noted above, which causes the checks to fail. Are those examples out of date? Maybe they can be dropped?

amoeba commented 4 years ago

Yeah, IIRC those coercions are out of date.

cboettig commented 4 years ago

ah, yeah, I see, we can just drop the old (S4) as() coercion, that's no longer needed as the set methods already return the right object. I've dropped those now and things look good check-wise.

Looks like NEWS.md hasn't been updated since last release -- wanna send a quick PR with any key changes we oughta mention? Then I'll get this and emld updated on CRAN.

amoeba commented 4 years ago

Sure, on its way shortly.