Updated shiny_attributes workflow with annotation support

ropensci / EML

Ecological Metadata Language interface for R: synthesis and integration of heterogenous data

https://docs.ropensci.org/EML

Other

97 stars 33 forks source link

Updated shiny_attributes workflow with annotation support #319

Closed ianbrunjes closed 3 years ago

ianbrunjes commented 3 years ago

Tests and check both pass locally. Since the changes to get/set attributes modify existing structures, no new tests were added (though certainly can be).

cboettig commented 3 years ago

LGTM. just fixed the test suite issues on the old releases, should be good now :crossed_fingers:

ianbrunjes commented 3 years ago

Hmmm, looks like the checks failed again on those missing packages after retrigger from your PR.

cboettig commented 3 years ago

ah, but those are just the checks on the branch, which doesn't have the changes. looks like we'll be fine after merge