About `update-tic.yml`

[pat-s]

Hi Adam,

in order for update-tic.yml to work, you need to add a secret with "workflow" scopes named "TIC_UPDATE" to your repo.

This can be easily done via tic::gha_add_secret(<secret>, "TIC_UPDATE").

Just letting you know since you are one of the few persons who were keen enough to try this new functionality :)

[adamhsparks]

Right, thanks for that. I had a feeling I was missing something here but got sidetracked and didn't investigate further.

[pat-s]

Hi Adam, just wondering if something is still unclear since the update-tic action is still erroring due to the lack of the secret?

[adamhsparks]

Is it? I thought it all ran fine.

tic::gha_add_secret(<secret>, "TIC_UPDATE")

Where <secret> was my GH PAT with a "workflow" scope. So, yes, I guess something wasn't clear to me because I thought it was working now. 😕

[adamhsparks]

Ah, I fixed a different issue that I was having. Dang.

OK, no, it's not clear. Sorry, I don't understand what needs to be done here.

[pat-s]

The PR creation fails because you renamed your default branch from master to main: https://github.com/ropensci/GSODR/runs/974227217?check_suite_focus=true#step:6:100

Maybe updating the action helps (just run tic::use_update_tic()) again. If not, you need to set the new default branch name in the "create-pull-request" action manually.

[adamhsparks]

Right, I thought that was the issue and I thought I'd fixed it for this. I'll try again! Thank you, again.

On Wed, 12 Aug 2020 at 15:54, Patrick Schratz notifications@github.com wrote:

The PR creation fails because you renamed your default branch from master to main: https://github.com/ropensci/GSODR/runs/974227217?check_suite_focus=true#step:6:100

Maybe updating the action helps (just run tic::use_update_tic()) again. If not, you need to set the new default branch name in the "create-pull-request" action manually.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ropensci/GSODR/issues/79#issuecomment-672621506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYMIAQ7UQ5HM7BHFQNT2SDSAIVARANCNFSM4PL4T74A .

-- Dr Adam H. Sparks http://adamhsparks.com/ Associate Professor of Field Crops Pathology | Centre for Crop Health | Office C313

Phone (+61) 07 46311948 | Mobile 0415 489 422 | Twitter @adamhsparks https://twitter.com/adamhsparks

Institute for Life Sciences and the Environment | Research and Innovation Division University of Southern Queensland | Toowoomba, Queensland | 4350 | Australia

[adamhsparks]

OK, I just feel dumb. I know that the YAML, update-tic.yml, specifies "main" not "master" but it's still failing when I trigger a build.

I thought that I had even updated that before I even ran tic::use_update_tic() just now, but now I know for sure that I've done both and it still fails.

[pat-s]

I do not see it failing. Note that the action is only run once a day in cron job. Where do you see it failing?

LGTM on the first look.

[adamhsparks]

I triggered a new run. Maybe I jay need to wait for tomorrow?

Adam H Sparks - Chat @ Spike [mx7vv]

On August 12, 2020 at 7:00 GMT, Patrick Schratz notifications@github.com wrote:

I do not see it failing. Note that the action is only run once a day in cron job. Where do you see it failing?

LGTM on the first look.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[pat-s]

You triggered a run for your main branch. This will not trigger a run for the update-tic YAML. The latter is configured CRON-only.

Let's wait for tmrw. Chances are that everything will just work then ;)

[adamhsparks]

I think this is finally fixed, here and on a couple other repositories where I’ve tried it. Will wait another 24hrs to be sure and then close this.

[adamhsparks]

All good! No error messages today. Thanks for your assistance, @pat-s.