search

ropensci / MODIStsp

An "R" package for automatic download and preprocessing of MODIS Land Products Time Series
https://docs.ropensci.org/MODIStsp
GNU General Public License v3.0
154 stars 50 forks source link

Hyperlink DOIs against preferred resolver #131

Closed katrinleinweber closed 3 years ago

katrinleinweber commented 6 years ago

Hello :-)

The DOI foundation recommends this new, secure resolver and Zenodo started using it for its badges as well. Accordingly, this PR updates all DOI links.

Cheers!

PS: In case the .bib files are generated automatically, is their source accessible to a PR like this one?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 87.345% when pulling d841ee1a5a19895966f3ba8311f76f29645286c4 on katrinleinweber:resolve-DOIs-securely into dbd0547008048f426f6ba0bb8ec6fbf1158888dc on lbusett:master.

katrinleinweber commented 6 years ago

Same error as in the last merged PR, so I guess it is not due to my change suggestion ;-)

lbusett commented 6 years ago

Hi,

thanks for the PR. I'll review it shortly. Do not worry about the coveralls fail: I still have to manage for it to work properly (can't manage to have GDAL properly configured).

Lorenzo

katrinleinweber commented 5 years ago

Sorry for the delay here in resolving these merge conflicts! This was a good opportunity to finally configure a proper mergetool, though :-)

ranghetti commented 3 years ago

I'm closing this pull request because old (I recently succeeded Lorenzo in maintaing the package, so I do not know details related to this PR and why it is wtill open). Feel free to reopen if needed.

katrinleinweber commented 3 years ago

Hi @ranghetti! It's technically still needed, assuming you want the links to adhere to the DOU foundations recommendation. It's not strictly necessary WRT any functionality ;-)

ranghetti commented 3 years ago

Thank you for your answer; I deepened this PR, noticing that almost all DOIs were already changed, so the PR is not yet necessary. Commit 53f95d404cd76499d56986e9b857a9f525215c9d fixed the two remaining ones.