ropensci / MODIStsp

An "R" package for automatic download and preprocessing of MODIS Land Products Time Series
https://docs.ropensci.org/MODIStsp
GNU General Public License v3.0
155 stars 51 forks source link

Add MCD19A1 to supported products #176

Closed eemaeda closed 5 years ago

eemaeda commented 5 years ago

Hi, It would be great if you could add the MODIS MAIAC (MCD19A1) to the list of supported products. https://lpdaac.usgs.gov/products/mcd19a1v006/ Thanks a lot! Regards, Eduardo

lbusett commented 5 years ago

@eemaeda

Thanks for signaling this. I added MCD19A1 to the supported products in the github version of MODIStsp. You can install and test it using:

remotes::install_github("ropensci/MODIStsp", ref = "master")

there are however two things to keep in mind:

  1. Because in MCD19A1 the different SDS have a different number of layers depending on latitude, it is not possible to "mosaic" multiple tiles as it is done for other products. Therefore, it is only possible to process one tile at a time,

  2. For similar reasons (i.e., multiple layers for the same date), it is not possible to create "meaningful" time series of the extracted variables. Therefor, creation of R RasterStacks, gdal VRT or ENVI meta files is disabled.

Let me know if this works for you. In the next days, I plan to add also the other products of the "MCD19 family".

Lorenzo

PS: Let us know if you notice other "missing" products!

eemaeda commented 5 years ago

Hi Lorenzo, Thanks a lot! However, I'm having some trouble installing the GitHub version. See error below. I have installed GTK+, and it seems to be running normally.

Warning: Failed to load RGtk2 dynamic library, attempting to install it. Please install GTK+ from http://ftp.gnome.org/pub/gnome/binaries/win32/gtk+/2.22/gtk+-bundle_2.22.1-20101227_win32.zip If the package still does not load, please ensure that GTK+ is installed and that it is on your PATH environment variable IN ANY CASE, RESTART R BEFORE TRYING TO LOAD THE PACKAGE AGAIN Error: package or namespace load failed for 'MODIStsp': .onLoad failed in loadNamespace() for 'RGtk2', details: call: NULL error: node stack overflow Error: loading failed Execution halted *** arch - x64 ERROR: loading failed for 'i386'

lbusett commented 5 years ago

hi @eemaeda ,

did you already try instructions provided here?

https://ropensci.github.io/MODIStsp/articles/installation.html#installing-on-windows

In particular, try installing and loading library RGtk2 beforehand: this should prompt installation of the required RGtk+ dlls.

eemaeda commented 5 years ago

Hi, Yes, I have followed all these instructions. The CRAN version is installing and running smoothly. The problem seems to be with the github installation.

lbusett commented 5 years ago

That's strange. The github and CRAN version are currently practically identical. What do you get if you try to load the RGtk2 library on a fresh R session?

eemaeda commented 5 years ago

I get nothing, it just loads the package normally. Strange indeed.

library(RGtk2) library(gWidgetsRGtk2) Loading required package: gWidgets Loading required package: cairoDevice

lbusett commented 5 years ago

Ok, what happens if you now run

gwindow("Test Window")
eemaeda commented 5 years ago
> gwindow("Test Window")
guiWidget of type: gWindowRGtk for toolkit: guiWidgetsToolkitRGtk2 
lbusett commented 5 years ago

And it opens a "gui"? Then the gui packages seem to be ok and MODISTSP should work. Cam you try again and resend the error log?

On Fri, 12 Jul 2019, 09:19 eemaeda, notifications@github.com wrote:

gwindow("Test Window") guiWidget of type: gWindowRGtk for toolkit: guiWidgetsToolkitRGtk2

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/176?email_source=notifications&email_token=ABCF3DJHD3XGUJT6XIO3C3LP7AWBVA5CNFSM4H5D6WEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZY5TGY#issuecomment-510777755, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCF3DLX4K2NP2AWCCDBGGTP7AWBVANCNFSM4H5D6WEA .

lbusett commented 5 years ago

Closing for now. Feel free to reopen if necessary