ropensci / MODIStsp

An "R" package for automatic download and preprocessing of MODIS Land Products Time Series
https://docs.ropensci.org/MODIStsp
GNU General Public License v3.0
155 stars 51 forks source link

Cannot accept output folder in MODIStsp GUI #215

Closed mhkhan81 closed 3 years ago

mhkhan81 commented 3 years ago

Hi I went through newly developed MODIStsp GUI found it very user friendly. But I come across an issue. I want to download multi-temporal ET data from MOD16A2 product. I have provide all the required information in MODIStsp GUI. but when finally come to browse the output folder for the downloaded and process data. the Browse doesn't accept the folder name. Further when I Run MODIStsp I got this following message in R console

Warning: Error in : $ operator is invalid for atomic vectors 74: observeEventHandler [C:/Users/mhkhan/Documents/R/win-library/3.6/MODIStsp/app/srv/mstp_prds_srv.R#225] 3: shiny::runApp 2: MODIStsp_GUI 1: MODIStsp

Could you please advise how to solve the issue.

Thanks

Khan

lbusett commented 3 years ago

Hi @mhkhan81

could you explain a bit more what happens when you click the browse button? Does the windows allowing to select the folder appear? If so, what happens when you try to select a folder? Also, could you share the results of

devtools::session_info()

Lorenzo

mhkhan81 commented 3 years ago

The devtools::session_info() is as under

Session info

setting value version R version 3.6.0 (2019-04-26) os Windows >= 8 x64 system x86_64, mingw32 ui RStudio language (EN) collate English_New Zealand.1252 ctype English_New Zealand.1252 tz Pacific/Auckland date 2020-09-18

[1] C:/Users/mhkhan/Documents/R/win-library/3.6 [2] C:/Program Files/R/R-3.6.0/library

On Thu, Sep 17, 2020 at 6:48 PM Lorenzo Busetto notifications@github.com wrote:

Hi @mhkhan81 https://github.com/mhkhan81

could you explain a bit more what happens when you click the browse button? Does the windows allowing to select the folder appear? If so, what happens when you try to select a folder? Also, could you share the results of

devtools::session_info()

Lorenzo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-693987022, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L42E4PAO6U7MYYSDFDSGGWNPANCNFSM4RM6LHKA .

mhkhan81 commented 3 years ago

Hi Lorenzo

Thanks for your email. The browse for attaching the folder path is blocked when moving the cursor to the record line; it shows a red circle with a line inside, which means cannot upload. After being unable to define the output folder. when run the MODItsp it give me the following result in R console: Warning: Error in : $ operator is invalid for atomic vectors _74: observeEventHandler [C:/Users/mhkhan/Documents/R/win-library/3.6/MODIStsp/app/srv/mstp_prds_srv.R#225] 3: shiny::runApp 2: MODIStsp_GUI 1: MODIStsp_

I will really appreciate if you could help me in extracting the MOD16A2 ET data.

Regards

Hamed

lbusett commented 3 years ago

@mhkhan81

Actually, to select the folder, you have to click on the "browse" buttons, and select it from the shinyFiles interface. Did you already try that?

Lorenzo

mhkhan81 commented 3 years ago

Yes I tried that but still is not working. By clicking the browse button no change occurs.

On Fri, Sep 18, 2020 at 7:37 PM Lorenzo Busetto notifications@github.com wrote:

@mhkhan81 https://github.com/mhkhan81

Actually, to select the folder, you have to click on the "browse" buttons, and select it from the shinyFiles interface. Did you already try that?

Lorenzo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694709750, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L4SWBWSD6DU6WZPPETSGME2ZANCNFSM4RM6LHKA .

lbusett commented 3 years ago

Clicking the button should open a window like this one:

image

If it is not happening, of course you can not select the folder!

mhkhan81 commented 3 years ago

What is the issue behind this?

On Fri, Sep 18, 2020 at 9:55 PM Lorenzo Busetto notifications@github.com wrote:

Clicking the button should open a window like this one:

[image: image] https://user-images.githubusercontent.com/4480397/93584119-268e4700-f9a5-11ea-935f-38bfb034fabb.png

If it is not happening, of course you can not select the folder!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694774356, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L5VU6TUYM3O24MDM6LSGMVCTANCNFSM4RM6LHKA .

lbusett commented 3 years ago

I have no clue, sorry... apparently, all your packages are up-to-date so it should be working... What browser are you using ?

mhkhan81 commented 3 years ago

When I run the MODIStsp library in R, the GUI automatically starts in Internet explorer. I am using Internet explorer 11.

On Fri, Sep 18, 2020 at 10:13 PM Lorenzo Busetto notifications@github.com wrote:

I have no clue, sorry... apparently, all your packages are up-to-date so it should be working... What browser are you using ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694782318, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5LZDXJMFUGZBUFEUOL3SGMXDDANCNFSM4RM6LHKA .

lbusett commented 3 years ago

It may be an issue with Internet Explorer. I only tested on Chrome. Would you be willing to try to install chrome and set it as your default browser to test ?

mhkhan81 commented 3 years ago

I am also using Chrome and its my default browser but MODIStsp goes to internet explorer.

On Fri, Sep 18, 2020 at 10:26 PM Lorenzo Busetto notifications@github.com wrote:

It may be an issue with Internet Explorer. I only tested on Chrome. Would you be willing to try to install chrome and set it as your default browser to test ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694788494, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L7NUV7ILLPREOHNPR3SGMYT7ANCNFSM4RM6LHKA .

mhkhan81 commented 3 years ago

With change of browser it works Now. Now i can browse the output folder. By running the GUI Nothing happen yet. My output folder is still empty.

On Fri, Sep 18, 2020 at 10:26 PM Lorenzo Busetto notifications@github.com wrote:

It may be an issue with Internet Explorer. I only tested on Chrome. Would you be willing to try to install chrome and set it as your default browser to test ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694788494, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L7NUV7ILLPREOHNPR3SGMYT7ANCNFSM4RM6LHKA .

lbusett commented 3 years ago

That's strange - it should go to the default browser....

I'll try to send you some code later to test if the problem is with shinyfiles/IE interaction.

mhkhan81 commented 3 years ago

In chrome I can browse the output folder, that problem is solved. But when clicking on the RUN MODIStsp button the GUI closed and the same few lines came in R console. No download or process happens in the output folder or in the R console.

On Fri, Sep 18, 2020 at 10:42 PM Lorenzo Busetto notifications@github.com wrote:

That's strange - it should go to the default browser....

I'll try to send you some code later to test if the problem is with shinyfiles/IE interaction.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694795217, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L4427DSKOHYB77N2N3SGM2QTANCNFSM4RM6LHKA .

lbusett commented 3 years ago

That is probably due to the fact that you did not select all processing options - I will soon post an update that will tell the user which specific inputs are missing / wrong.

mhkhan81 commented 3 years ago

Yes you were right as I was only selecting ET. But now after selecting all the options in the given selectors and it works. I really appreciate your prompt response and help.

On Sat, Sep 19, 2020 at 12:07 AM Lorenzo Busetto notifications@github.com wrote:

That is probably due to the fact that you did not select all processing options - I will soon post an update that will tell the user which specific inputs are missing / wrong.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/MODIStsp/issues/215#issuecomment-694829778, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARAE5L77TOFXCTHFMNPTXCDSGNEPVANCNFSM4RM6LHKA .