ropensci / MODIStsp

An "R" package for automatic download and preprocessing of MODIS Land Products Time Series
https://docs.ropensci.org/MODIStsp
GNU General Public License v3.0
155 stars 50 forks source link

Problem with GUI in GitHub version 2.0.6.9000 of MODIStsp #245

Closed 5partanen closed 2 years ago

5partanen commented 2 years ago

Issue description When using MODIStsp through the GUI, after setting all my parameters and clicking the "Run MODIStsp" button, an error occurs (see output below). The same error occurs when trying to save a parameter file as well. The MODIStsp(gui = FALSE) function works as expected when run in R. Another small note - in the documentation for the MODIStsp() function (https://docs.ropensci.org/MODIStsp/reference/MODIStsp.html), the options for argument "out_res_sel" are stated as "Native" or "User Defined". But when running MODIStsp() in R, "User Defined" throws an error. This is fixed by making the argument "Resampled" instead.

Reproducible example

## 
library(MODIStsp)
MODIStsp(GUI = TRUE)
# I will attach a version of the parameters JSON file that I was able to save with the old version of  the GUI. It will have the wrong MODIStsp version and the wrong product version (6 instead of 6.1) since I can't save a new version of the file through the GUI.

Expected and actual behavior

## 
Listening on http://127.0.0.1:7409
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
old-style crs object detected; please recreate object with a recent sf::st_crs()
bounding box has potentially an invalid value range for longlat dataError in [[: attempt to select less than one element in get1index  3: shiny::runApp
  2: MODIStsp_GUI
  1: MODIStsp-

System information Provide here the output of the following R commands: sessionInfo()

R version 4.0.5 (2021-03-31) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 19043)

Matrix products: default

locale: [1] LC_COLLATE=English_Canada.1252 LC_CTYPE=English_Canada.1252 LC_MONETARY=English_Canada.1252 LC_NUMERIC=C LC_TIME=English_Canada.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] shiny_1.7.1 terra_1.4-7 MODIStsp_2.0.6.9000 remotes_2.4.1

loaded via a namespace (and not attached): [1] shinyalert_2.0.0 httr_1.4.2 sass_0.4.0 shinyFiles_0.9.0 jsonlite_1.7.2 bslib_0.3.1 assertthat_0.2.1 sp_1.4-5
[9] yaml_2.2.1 pillar_1.6.4 lattice_0.20-41 glue_1.4.2 digest_0.6.28 promises_1.2.0.1 htmltools_0.5.2 httpuv_1.6.3
[17] gdalUtilities_1.2.0 pkgconfig_2.0.3 raster_3.5-2 purrr_0.3.4 xtable_1.8-4 fontawesome_0.2.2 processx_3.5.2 mapedit_0.6.0
[25] later_1.3.0 tibble_3.1.5 proxy_0.4-26 generics_0.1.0 ellipsis_0.3.2 cachem_1.0.6 shinyjs_2.0.0 withr_2.4.2
[33] cli_3.0.1 magrittr_2.0.1 crayon_1.4.2 mime_0.12 evaluate_0.14 ps_1.6.0 fs_1.5.0 fansi_0.5.0
[41] xts_0.12.1 xml2_1.3.2 class_7.3-18 pkgbuild_1.2.0 shinydashboard_0.7.2 tools_4.0.5 data.table_1.14.2 prettyunits_1.1.1
[49] lifecycle_1.0.1 stringr_1.4.0 callr_3.7.0 jquerylib_0.1.4 compiler_4.0.5 e1071_1.7-9 tinytex_0.34 rlang_0.4.11
[57] classInt_0.4-3 units_0.7-2 grid_4.0.5 rstudioapi_0.13 rappdirs_0.3.3 htmlwidgets_1.5.4 crosstalk_1.1.1 base64enc_0.1-3
[65] leafem_0.1.6 bitops_1.0-7 rmarkdown_2.11 codetools_0.2-18 DBI_1.1.1 curl_4.3.2 R6_2.5.1 zoo_1.8-9
[73] knitr_1.36 dplyr_1.0.7 rgdal_1.5-27 fastmap_1.1.0 utf8_1.2.2 rprojroot_2.0.2 KernSmooth_2.23-18 stringi_1.7.5
[81] parallel_4.0.5 Rcpp_1.0.7 png_0.1-7 vctrs_0.3.8 sf_1.0-3 leaflet_2.0.4.1 tidyselect_1.1.1 xfun_0.26

packageVersion("MODIStsp")

[1] ‘2.0.6.9000’

Additional context

Scientific publication

MCD18A2_test_params.txt

ranghetti commented 2 years ago

Sorry, a typo in the code of the last update. Downloading again the Github version 2.0.6.9001 should solve. Please let me know,

5partanen commented 2 years ago

That fixed it! Running MODIStsp() through the GUI now works as expected.

Thanks a lot!