search

ropensci / MODIStsp

An "R" package for automatic download and preprocessing of MODIS Land Products Time Series
https://docs.ropensci.org/MODIStsp
GNU General Public License v3.0
155 stars 50 forks source link

Fix image location for pkgdown #260

Closed maelle closed 1 year ago

maelle commented 1 year ago 
Missing images in '/tmp/Rtmpy2xPLS/MODIStsp-source/index.md': 'reference/figures/irea_logo.png'
ℹ pkgdown can only use images in 'man/figures' and 'vignettes'

happy to help if needed!

maelle commented 1 year ago

What's the goal of this bot workflow, out of curiosity @ranghetti?

ranghetti commented 1 year ago

I introduced the bot after a career change that did not allow me to continue providing assistance for the packages which I was maintaining. Currently I am limiting to strictly necessary package maintenance (e.g. #257). If it would be possible to have an help from rOpenSci community I would be happy to remove the bot (I would have deepen this topic as soon as I would have had time). Regarding the issue, I will manage it as soon as possible.

maelle commented 1 year ago

Do you mean you'd need to recruit a co-maintainer? We could add a call for co-maintainer in the next newsletter. (or even a new maintainer if you'd prefer to step down -- thanks for your work on this package until now in any case) You could open an issue in this repo describing what tasks often occur, and we'd link to it. How would that sound?

ranghetti commented 1 year ago

You could open an issue in this repo describing what tasks often occur, and we'd link to it. How would that sound?

@maelle thank you, I will move in this direction as soon as possible.

maelle commented 1 year ago

Thanks, please ping me when you've done that. :pray:

ranghetti commented 1 year ago

In the meanwhile, last commit should have fixed the topic of this issue. (Ps. I am also seeing this https://github.com/r-universe/ropensci/actions/runs/2977880182 , in which the error is not present even if the run is before the fix)

maelle commented 1 year ago

Yes this is a warning not a bug, but I reported it because missing images can be annoying. I saw it because there used to be an error too (#259). Thank you!