ropensci / NLMR

📦 R package to simulate neutral landscape models 🏔
https://ropensci.github.io/NLMR/
65 stars 17 forks source link

Add all vignette deps to DESCRIPTION #88

Closed maelle closed 2 years ago

maelle commented 2 years ago

It seems e.g. viridis is missing, but there might be more? Thank you!

https://github.com/r-universe/ropensci/runs/4691817799?check_suite_focus=true

Reading 'vignettes/articles/visualize_nlms.Rmd'
-- RMarkdown error -------------------------------------------------------------
Scale for 'fill' is already present. Adding another scale for 'fill', which
will replace the existing scale.
Loading required package: lattice
Loading required package: sp
Quitting from lines 148-160 (visualize_nlms.Rmd) 
Error in library("viridis") : there is no package called 'viridis'
In addition: Warning messages:
1: `guides(<scale> = FALSE)` is deprecated. Please use `guides(<scale> = "none")` instead. 
2: In nlm_mpd(ncol = 50, nrow = 50, roughness = 0.6) :
  nlm_mpd changes the dimensions of the RasterLayer if even ncols/nrows are choosen.
--------------------------------------------------------------------------------
Error : Failed to render RMarkdown

@marcosci

marcosci commented 2 years ago

Sorry, very busy months. Now again ahead of things and trying to fix this.

97c8df6a812595becd7a4bb11776f9d904300922 ... does this fix things? :) Don't know if I can trigger a rebuild ropensci universe and check this myself ... a bit out of the package maintaining game 😅

maelle commented 2 years ago

The build will trigger itself with the commit, hourly IIRC. I'll re-check https://ropensci.r-universe.dev/ui#builds later today

Thank you! I can make a PR next week if it wasn't enough, happy to help.