search

ropensci / PostcodesioR

API wrapper around postcodes.io - free UK postcode lookup and geocoder
https://docs.ropensci.org/PostcodesioR
39 stars 7 forks source link

Is there a 100 bulk limit? #8

Closed layik closed 4 years ago

layik commented 4 years ago

Awesome package to start with!

I discovered via using the package that there is a 100 bulk lookup limit. Correct? If so, I am happy to contribute to make that clear rather than returning a In extract_results(r) : Bad Request (HTTP 400). error which lead me to sanity check my postcodes.

Thanks and hoping it is a valid "issue".

erykwalczak commented 4 years ago

Thanks for opening the issue. It is valid. I agree that the error message is not clear. I mentioned this limit in the function documentation. Feel free to send a PR. Also, bear in mind that the GitHub version is slightly ahead of CRAN so please use this version to make changes.

layik commented 4 years ago

OK, so digging further this is strictly from postcodes.io and hence the 400 error. Will send a tiny PR without fiddling too much with bulk_postcode_lookup function which would do with a little more but will keep it to the issue.

erykwalczak commented 4 years ago

Thanks. Fixed in PR #9