search

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

changes to nexml_read #131

Closed sckott closed 8 years ago

sckott commented 8 years ago

switch to generic S3 function, with methods for character, XMLInternalDocument and XMLInternalNode added more examples for all the possible inputs changed character input checking to hopefully fail well when character input not appropriate

addresses #123

@cboettig feel free to not accept this - there may be good reason not to switch approaches that I'm not thinking of. Can add tests, where's the best place to put those?

cboettig commented 8 years ago

Nice. Can you add a test that shows this fixes the bug in #123?

sckott commented 8 years ago

yeah

sckott commented 8 years ago

added

hlapp commented 8 years ago

Looks great!

xu-hong commented 8 years ago

It works great! Just changed the reading nexml part https://github.com/xu-hong/rphenoscape/commit/38eb615e8dbc041b9e814e584cad817a52f220b4 in rPhenoscape @hlapp