Fix blank node behavior of nested meta elements

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R

https://docs.ropensci.org/RNeXML

Other

13 stars 9 forks source link

Fix blank node behavior of nested meta elements #197

Closed cboettig closed 5 years ago

cboettig commented 5 years ago

Includes test using SPARQL query to verify blank node behavior.

@hlapp Sorry I got a bit confused about this one last night, too little sleep. Anyway, thanks for reporting and I think this should resolve the issue. Check out the added unit test for a quick demo parsing the nested meta as RDF and querying to illustrate that we do get a blank node.

Fixes #196.

hlapp commented 5 years ago

I added a couple of changes. One fixes a typo you made, which went unnoticed due to a missing test.

The other (b9508ab640dd697081acfe9e4cd3bd806114e618) I think addresses the issue that the nested meta elements still weren't getting parsed (and thus also not serialized, i.e., they would essentially be lost). Includes tests as well.

cboettig commented 5 years ago

Nice, thanks!