search

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

Fixes several bugs in handling metadata #202

Closed hlapp closed 5 years ago

hlapp commented 5 years ago

In particular this applies to meta()-generated meta element, and more deeply nested meta elements (such as those generated by simmap).

This will need to be rebased into #201, but the issues being corrected have nothing to do with the prefixing of class names undertaken there, so I decided to put them against master first.

hlapp commented 5 years ago

@cboettig do you want to take a look? It's a bunch of smaller corrections that set the stage for a larger refactor of meta, which I have ready to go once I can rebase this in.

cboettig commented 5 years ago

@hlapp yup, this all looks good to me.

Would it be better to merge this first or #199 first? Feel free to merge in whatever order simplifies the rebase issues.