search

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

Adds comparing simplify = FALSE for metadata table #221

Closed hlapp closed 5 years ago

hlapp commented 5 years ago

Also regenerated the README.md.

hlapp commented 5 years ago

BTW I think we're at the point that the next release is due.

cboettig commented 5 years ago

Nice. Wondering if we should clean up the README a bit more while we are at it. I can clean up the badge list (we don't need two coverage badges, looks like our appveyor setup needs mending since it's not active...) but there's a bit of a philosophical divide between whether pkg root README should be a more minimal motivation/install/quickstart (with the details handled in vignettes linked from the readme) or a more complete all-the-essentials style document. For the former it would be good to run pkgdown::build_site() to get an HTML version of the docs and vignettes as well.... thoughts?

Yes, definitely need to plan a new release on this as well.

hlapp commented 5 years ago

Indeed I had similar thoughts and had noticed pkddown. I moved this to its own issue (#222), continuing there.

hlapp commented 5 years ago

@cboettig am I right that this has been obsoleted by #223 and #226?

cboettig commented 5 years ago

whoops, I don't think I pulled this into #226 yet...

hlapp commented 5 years ago

Most of it is there in #226, actually. The only thing that's not is the hunk about showing simplify=FALSE. I assumed you decided that doesn't fit well into the intro vignette?

cboettig commented 5 years ago

Ah, good . Yeah, I don’t think simplify=FALSE has a compelling enough use case, almost always would want TRUE anyway

On Fri, Dec 7, 2018 at 5:07 PM Hilmar Lapp notifications@github.com wrote:

Most of it is there in #226 https://github.com/ropensci/RNeXML/pull/226, actually. The only thing that's not is the hunk about showing simplify=FALSE https://github.com/ropensci/RNeXML/pull/221/files#diff-5140cd39fa2897e01ffbfb8db0999940R104. I assumed you decided that doesn't fit well into the intro vignette?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ropensci/RNeXML/pull/221#issuecomment-445416110, or mute the thread https://github.com/notifications/unsubscribe-auth/AANleogmLVa71uU4sycktnPHoEDMqeYQks5u2xC0gaJpZM4Y25bk .

--

Carl Boettiger http://carlboettiger.info/

hlapp commented 5 years ago

So close this one then? I'll assume you meant yes.