search

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

Do not add `ter` namespace by default. #227

Closed cboettig closed 5 years ago

cboettig commented 5 years ago

@hlapp following up on #154 here... I've just dropped ter from the default namespaces added by RNeXML (really no idea where I got that from in the first place...)

I didn't alter any of the nexml files in inst/examples that use ter. I didn't detect ter being used in any of the tests, and the tests seem to be passing locally. (Compare: GitHub search for ter in repo code).

I think this should close out #154, and then maybe we're ready to package up another release? Need to update NEWS.md again...

hlapp commented 5 years ago

Thanks for just trying that 😄 I thought I had used that in some of the prefix-expansion tests or examples, but am glad to learn I didn't.

I didn't alter any of the nexml files in inst/examples that use ter.

It shouldn't matter if a file uses it, because when reading, the file's namespace declarations take precedence (since #219). That is, the worst that would happen then is that when writing the resulting nexml object back out, the dcterms namespace would get added. (In theory, it might be nice to add only those namespaces that are actually used. But there's no real penalty to be paid that I'm aware of for having extraneous namespace definitions in the header, and so trying to accomplish this doesn't seem worth the effort.)