ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

Cut new release to CRAN? #228

Closed hlapp closed 5 years ago

hlapp commented 5 years ago

Looks like it's been time to re-release to CRAN after the changes following v2.2.0?

cboettig commented 5 years ago

Thanks, yup I think this is somewhat stuck in queue behind releasing the taxadb package we are now using in place of taxize, which isn't on CRAN yet (will want it to go through rOpenSci review first, which is quite thorough these days).

Since it's a Suggested package only we could release it ahead of that, but would complicate installation for those features by requiring an additionalRepository

hlapp commented 5 years ago

I don't think it's a good idea to have this release held up in a manner that's not very predictable (e.g., as opposed to a dependency that needs some bugs fixed and re-released, as it was originally the case with taxize). IMHO resolution of taxon names against databases is really a side issue to the core purpose of RNeXML, and the only reason it arguably even has a place here is that replacing taxon metadata in a nexml object is kind of non-trivial in R's pass-by-value paradigm.

In contrast, the metadata handling, where most of the changes are, is arguably one of the core use-cases for NeXML to start with, isn't it?

So, long story short, I have an intern or two starting in a week or two on Rphenoscape, and we'll have to bring in the changes pending for release. It'd be way smoother if those simply came in through CRAN.

cboettig commented 5 years ago

Yeah, I agree, that's why the taxa lookup stuff is only a suggested dependency anyway. This sounds good to me. I'll try and get it onto CRAN by using the additional repositories mechanism.

cboettig commented 5 years ago

@hlapp I've pushed a new release to CRAN with the Additional_repositories mechanism. 🤞 we'll see what they say before I cut a new release on GitHub.

cboettig commented 5 years ago

On CRAN now