ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

Message from CRAN #247

Closed cboettig closed 4 years ago

cboettig commented 4 years ago

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_RNeXML.html.

The new check problems are from a recent upgrade of package 'tibble' to version 3.0.0, with breaking changes described at https://tibble.tidyverse.org/news/index.html.

We understand that you were not informed by the tibble maintainer about the upcoming breakage, and many of us currently have very little time to work on their packages. Can you nevertheless please try to fix your package as quickly as possible? If the description of the breaking changes does not suffice, please feel free to ask the tibble maintainer for help.

Please correct before 2020-04-22 to safely retain your package on CRAN.

cboettig commented 4 years ago

@hlapp No idea what's up with this. Perhaps we can avoid tibble entirely? Maybe @krlmlr has some insight?

krlmlr commented 4 years ago

I double-checked, can replicate the error with tibble 3.0.0 but not with tibble 2.1.3. It's a weird one, need to understand the cause.

krlmlr commented 4 years ago

Reprex:

loadNamespace("RNeXML")
#> <environment: namespace:RNeXML>
unloadNamespace("RNeXML")
#> Error in .mergeMethodsTable(generic, mtable, tt, attach): trying to get slot "defined" from an object of a basic class ("environment") with no slots

Created on 2020-04-03 by the reprex package (v0.3.0)

Removing importFrom(cli,*) from tibble's NAMESPACE fixes the problem, but only after RNeXML is reinstalled. Suspecting a buglet in R which we need to work around.

I can submit a tibble update well before the deadline.

cboettig commented 4 years ago

@krlmlr Thanks so much for the quick reply and tracking this one down, it had me totally stumped. That would be terrific if you could patch this from tibble end, and thanks for all the work you do for our community!

closing with :crossed_fingers:

hlapp commented 4 years ago

Removing importFrom(cli,*) from tibble's NAMESPACE fixes the problem, but only after RNeXML is reinstalled. Suspecting a buglet in R which we need to work around.

I can submit a tibble update well before the deadline.

Many thanks @krlmlr!