search

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

Replaces invocations of dplyr deprecated funcs with supported #253

Closed hlapp closed 1 year ago

hlapp commented 1 year ago

In particular, the replacements concern select(), mutate(), and rename_() invocations.

As a result, this drops one dependency (lazyeval::interp), and some expressions are aguably clearer than they were before.

Fixes #250.

hlapp commented 1 year ago

Looks like someone needs to update the CircleCI test configuration?

cboettig commented 1 year ago

yeah I think CircleCI and appveyor are basically deprecated, need to figure out how to deactivate those hooks.

Not sure what is behind the other two failing checks, though looks like it could be connected to potentially broken functionality in the taxize helper?

hlapp commented 1 year ago

Not sure what is behind the other two failing checks, though looks like it could be connected to potentially broken functionality in the taxize helper?

Yes that's what it looks like. I checked and confirmed that the input (the taxon labels extracted from the nexml object) to the taxalight::get_ids() call is correct.

cboettig commented 1 year ago

ok thanks. merging this, and can take a look at the taxalight call later since it's an unrelated issue anyway. as it's passing on some of the platforms it might just be an issue with LMDB config