search

ropensci / RNeXML

Implementing semantically rich NeXML I/O in R
https://docs.ropensci.org/RNeXML
Other
13 stars 9 forks source link

`env_unlock()` will be removed from rlang #258

Open lionel- opened 2 months ago

lionel- commented 2 months ago

Hello, just a heads up that we'll remove env_unlock() from rlang in a future version (undetermined timeline as of yet) because it's implemented using non-API calls that CRAN has started to lint. Could you try and find another approach please?

cboettig commented 2 months ago

@lionel- Thanks for the heads up. Do you have a better suggestion then for how to deal with the namespace conflict that is created by cli ? The current use of env_unlock() in this package was provided by @gaborcsardi to address the conflict between competing classes of the same name, https://github.com/ropensci/RNeXML/issues/251#issuecomment-1031996431

gaborcsardi commented 2 months ago

The root of the issue was fixed in R 4.2.0, so you should not need this workaround any more.

cboettig commented 2 months ago

perfect, thanks @gaborcsardi !

hlapp commented 2 months ago

@cboettig looks like you addressed this in f94903a but there is no PR and the build fails. Would you mind if I reopen this and we create a PR for documentation?

cboettig commented 2 months ago

@hlapp yes thanks, I was sloppy on that!

Regarding the builds, it's probably time to update the workflow script as well, which can be done with usethis::use_github_actions()