Closed fmichonneau closed 10 years ago
@fmichonneau thanks for your feedback!
Would you mind opening a new issue for your list of additional things to correct/address? (A single bulleted list is fine, you can use github's - [ ] item
notation to give me check boxes for each item). All good stuff!
No problem, I'll be working on it now!
Hi,
I went through the manuscript quickly, and provided some edits/comments. RNeXML is really exciting and the manuscript provides nice examples of how powerful and useful this package is. Below are a few additional comments.
I think the manuscript will benefit from having a quick paragraph about some details of the XML file format. The manuscript does a good job at emphasizing that XML is well suited to store data/metadata associated with phylogenetic studies, but the manuscript lacks a section on how a XML file is organized and the definitions of some concepts that are used in the manuscript. For instance, in the section "Custom metadata extensions", the second paragraph reads:
half of the words in this sentence are mentioned for the first time here (or have been used but not defined), and it is also the first time in the manuscript that the actual content of an XML file is shown. I realize that one of the advantages of this package is to not have to deal with XML files per se, but providing, in the introduction, a brief overview of the XML format and a definition of some of the concepts of the terms used would clarify the manuscript.
dc
, aprism
and askos
prefix and what could be the difference between them. Talking about the scope of each namespace, and why several need to be used would be useful. Maybe bringing in Darwin Core that many people would have heard of might also be worthwhile.phylo
class is referred to asape::phylo
and other times as justphylo
, and simmap is also sometimessimmap
Let me know if you have any questions or need additional feedback.