Port tests to TRAVIS - Githubissues

ropensci / RSelenium

An R client for Selenium Remote WebDriver

https://docs.ropensci.org/RSelenium

344 stars 81 forks source link

Port tests to TRAVIS #89

Open johndharrison opened 8 years ago

johndharrison commented 8 years ago

Travis now runs Docker containers and R is a first class citizen. Can move tests to TRAVIS. Also tackles changes in upstream R regarding testing.

[x] Add api tests
[x] Add alerts tests
[x] Add cookie tests
[x] Add executing javascript tests
[ ] Add frame switching tests
[x] Add page loading tests
[x] Add screenshot tests
[x] Add util function tests

johndharrison commented 8 years ago

RJSONIO fails to install with devtools. In addition RJSONIO has conflicts with covr.

In light of this jsonlite and rjson were looked at as direct replacements. rjson was chosen as only the fromJSON function was required. jsonlite has useful options to convert JSON to R objects etc. Using it as a replacement for RJSONIO presented more issues and was less straight-forward then using rjson.

johndharrison commented 8 years ago

The utility functions in util.R are mainly tested using mocking.