ropensci / Rpolyhedra

A polyhedra database scraped from public available sources using R6 (OOP) and 'rgl' visualizing capabilities.
https://docs.ropensci.org/Rpolyhedra
Other
12 stars 6 forks source link

devtools::check fails #37

Open kenarab opened 4 years ago

kenarab commented 4 years ago

Maybe it has to do with R 3.6.0 standards. We need to solve it for normalizing Travis CI building

> checking Rd cross-references ... WARNING
  Missing link or links in documentation object 'PolyhedronStateDefined.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’

  Missing link or links in documentation object 'PolyhedronStateDeserializer.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’

  Missing link or links in documentation object 'PolyhedronStateDmccooeyScraper.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’

  Missing link or links in documentation object 'PolyhedronStateNetlibScraper.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’

  See section 'Cross-references' in the 'Writing R Extensions' manual.

> checking whether package ‘Rpolyhedra’ can be installed ... NOTE
  See below...

> checking Rd files ... NOTE
  prepare_Rd: PolyhedraDatabase.class.Rd:12-14: Dropping empty section \details

── Test failures ──────────────────────────────────────────────────────────────────────────────────── testthat ────

> library(Rpolyhedra)
> library(stringr)
> library(futile.logger)
> library(rgl)
> library(geometry)
> library(testthat)
> 
> 
> #Change threshold to ERROR. Comment out/change if verbosity required for development
> futile.logger::flog.threshold(futile.logger::ERROR)
NULL
> 
> #' getDataDirMockedTest mocked function for a temp dest folder for testing proposes
> 
> 
> 
> testthat::test_check("Rpolyhedra")
── 1. Error: create minimal db (@test_db_lib.R#5)  ────────────────────────────────────────────────────────────────
cannot change value of locked binding for '.scrape.config'
Backtrace:
 1. testthat::expect_equal(selectDataEnv("PACKAGE"), "PACKAGE")
 4. Rpolyhedra:::selectDataEnv("PACKAGE")
 5. Rpolyhedra:::updatePolyhedraDatabase()
 6. Rpolyhedra:::setPackageEnvir(".scrape.config", "pkg-minimal")
 7. base::assign(x = variable.name, value = value, envir = asNamespace("Rpolyhedra"))

── 2. Error: test on env lib functions (@test_env_lib.R#20)  ──────────────────────────────────────────────────────
cannot change value of locked binding for '.scrape.config'
Backtrace:
 1. testthat::expect_equal(selectDataEnv(env = "PACKAGE"), "PACKAGE")
 4. Rpolyhedra:::selectDataEnv(env = "PACKAGE")
 5. Rpolyhedra:::updatePolyhedraDatabase()
 6. Rpolyhedra:::setPackageEnvir(".scrape.config", "pkg-minimal")
 7. base::assign(x = variable.name, value = value, envir = asNamespace("Rpolyhedra"))

── 3. Error: test on package lib functions (@test_package_lib.R#16)  ──────────────────────────────────────────────
cannot change value of locked binding for '.scrape.config'
Backtrace:
 1. testthat::expect(!is.null(updatePolyhedraDatabase()), failure_message = "updatePolyhedraDatabase cannot be null")
 2. Rpolyhedra:::updatePolyhedraDatabase()
 3. Rpolyhedra:::setPackageEnvir(".scrape.config", "pkg-minimal")
 4. base::assign(x = variable.name, value = value, envir = asNamespace("Rpolyhedra"))

══ testthat results  ══════════════════════════════════════════════════════════════════════════════════════════════
[ OK: 634 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 3 ]
1. Error: create minimal db (@test_db_lib.R#5) 
2. Error: test on env lib functions (@test_env_lib.R#20) 
3. Error: test on package lib functions (@test_package_lib.R#16) 

Error: testthat unit tests failed
Execution halted

1 error x | 1 warning x | 2 notes x
sckott commented 3 years ago

👋🏽 We (rOpenSci staff) occasionally go through repositories in our org and try to help out as needed. It seems like your Travis-CI builds https://travis-ci.org/github/ropensci/Rpolyhedra/builds have been failing for a while. In addition, the builds we do across all rOpenSci packages are failing https://github.com/r-universe/ropensci/runs/1134128901?check_suite_focus=true#step:7:17 for macOS. Last, Travis-CI has recently announced a change in their business, so you may want to switch to another CI like github actions or similar

kenarab commented 3 years ago

Hi Scott. Thank you for your message. We had a inherited problem because Roxygen and R6 lack of documentation. The builds failing problem has nothing to do with Rpolyhedra functionality. We already found the solution but have to make a space frame for pushing a new release.

In the next days we will fix the issue. Thank you too about Travis policy change.

Best, Leo & Ale.

On Wed, Dec 9, 2020 at 7:12 PM Scott Chamberlain notifications@github.com wrote:

👋🏽 We (rOpenSci staff) occasionally go through repositories in our org and try to help out as needed. It seems like your Travis-CI builds https://travis-ci.org/github/ropensci/Rpolyhedra/builds have been failing for a while. In addition, the builds we do across all rOpenSci packages are failing https://github.com/r-universe/ropensci/runs/1134128901?check_suite_focus=true#step:7:17 for macOS. Last, Travis-CI has recently announced https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing a change in their business, so you may want to switch to another CI like github actions or similar

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ropensci/Rpolyhedra/issues/37#issuecomment-742095682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWMBVQQO5534FFNJSTNX5LST7Y37ANCNFSM4KIPD54Q .

-- alejandro baranek @ken4rab https://twitter.com/ken4rab qbotics http://qbotics.tumblr.com/ | rpolyhedra https://qbotics.shinyapps.io/rpolyhedra-explorer/?_inputs_&polyhedron_color=%22%23FF0000FF%22&polyhedron_name=%22Triakis%20Tetrahedron%22&polyhedron_source=%22dmccooey%22&show_axes=false | surferinvaders http://surferinvaders.tumblr.com | algebraic-soundscapes http://imaginary.org/content/algebraic-soundscapes | surfer-shuffle http://imaginary.org/program/surfer-shuffle

sckott commented 3 years ago

Great, thanks!