search

ropensci / allodb

An R package for biomass estimation at extratropical forest plots.
https://docs.ropensci.org/allodb/
GNU General Public License v3.0
36 stars 11 forks source link

giving more flexibility in the weighting scheme #114

Closed cpiponiot closed 4 years ago

cpiponiot commented 4 years ago

For now there is no arguments of the get_biomass function that allow the user to change the parameters of the weighting scheme (mentioned in the allodb manuscript: "The choices of weighting functions and parameter values are somehow arbitrary, selected based on our current understanding of the principles of allometric equations and experimentation with various options, and may be adjusted based on user discretion")

Should I add these arguments in the get_biomass function, with the same default values as the ones already given now?

gonzalezeb commented 4 years ago

I think that would be good, it is kind of facilitating steps to the user on how to change parameters.

teixeirak commented 4 years ago

Yes, I think that's good, assuming its easy to implement.