ropensci / allodb

An R package for biomass estimation at extratropical forest plots.
https://docs.ropensci.org/allodb/
GNU General Public License v3.0
36 stars 11 forks source link

In `new_equations()` (and elsewhere) avoid `subset()` #154

Closed maurolepore closed 3 years ago

maurolepore commented 3 years ago

?subset():

This is a convenience function intended for use interactively. For programming it is better to use the standard subsetting functions like [, and in particular the non-standard evaluation of argument subset can have unanticipated consequences.

Else prefer dplyr::filter() and dplyr::select(), which like subset() use non-standard evaluation but have their own "tidy evel" framework to program safely with them.