search

ropensci / allodb

An R package for biomass estimation at extratropical forest plots.
https://docs.ropensci.org/allodb/
GNU General Public License v3.0
36 stars 11 forks source link

Fix corrupt data to allow support for R 3.4 #193

Closed maurolepore closed 3 years ago

maurolepore commented 3 years ago

Closes #192

This PR adds support for R 3.4. Before we supported R >= 3.5. With this, more users should feel that the package "just works". Also it makes it work with the released + 4 old-releases -- which is a high standard used by the tidyverse team. While that may sometimes be too ambitious, I think it's a good benchmark to aim for, particularly if we plan to make this package widely available on CRAN.

--

@gonzalezeb, where did the data set shrub_species come from? I saw it in data/ and it seems to now work with older versions of R. So I loaded it, stored it in data-raw, and copied it to data/ as usual with usethis::use_data(). This seems to work fine now, but I would be good to record the source of this and other datasets, maybe as a comment in the file data-raw/dataset-name.R, e.g. data-raw/shrub_species.R.

gonzalezeb commented 3 years ago

I don't remember where this dataset comes from, maybe @cpiponiot can tell us??

maurolepore commented 3 years ago

@gonzalezeb this PR is ready for review.