teixeirak
commented
5 years ago More broadly than the comment above, I'm finding the tables difficult to work with from a "user" standpoint, and in some cases I think they may be missing important information. Here's my running list (including modification of the one above):
-
[x] The equations table needs a field to indicate the taxa on which it was developed. This is (partially) given in the sitespecies table (
equation_taxa), but upon looking at the chojnacky_2014_ugbe equations, I noted that it includes only the taxa to which the species in question belongs and not full information about taxa used in the equation. For example, it (1) doesn't differentiate between "Abies < 0.35 spg" (eq. 4872ed) and Abies≥ 0.35 spg (eq. 74dd65) or (2) give the information that taxa other than the target taxa were included in the allometry ("Fabaceae/ Juglandaceae, other"; eq. 7f7777). This will be something for Erika to decide on, but here's my recommendation: (1) moveequation_taxato the equations table, and modify to indicate when multiple taxa were included (e.g., "Fabaceae/ Juglandaceae"); (2) add a field to equations tableoriginal_equation_idor such so that equations can be easily matched to those in the original publication (for chojnacky_2014_ugbe, this would be, e.g., "Abies≥ 0.35 spg"); (3) add a field in sitepecies briefly describing the type of trees for which the equation was developed (e.g., "Abies≥ 0.35 spg", "Fabaceae/ Juglandaceae, other", "Pinus saplings"). The purpose of this field will be for users to be able to evaluate how closely a certain species is matched to an equation without having to merge tables and examine several fields. -
[x] Related to the above -- and (partly) solved if we follow my recommendations)-- is the issue of the sitespecies table indicating the appropriate range of dbh. We'd originally planned that this table would have its own minDBH and maxDBH fields, indicating the DBH range over which the equation would be applied. This may be different from the min and max in the equations table when (1) there's >1 option for a given DBH or (2) we decide that the best option is to extrapolate beyond the min/max of the equation that we have. We've now been writing/ planning the code to automate this (e.g., issue #17), so maybe that's not needed anymore (although potentially useful to communicate to the user what's being applied). If we implement my recommendation 3 in the item above, that could at least give a sense of which equations are being applied (e.g., "Pinus saplings" and "Pinus >5cm").
-
[x] The current
warningfield (equations table) is currently notes/ warnings to ourselves. I thought the purpose of that field would be to generate warnings to the user when potentially untrustworthy equations are used. Renamenotes? Or do we need a field warning about the equations themselves? -
[x] Related to the above, it seems that the sitespecies table would be an appropriate place for a
warningfield. Warnings would be generated when there's no truly appropriate equation for a certain species. An example warning (currently in notes) might be "using allometries for Pseudotsuga menziesii as generic small conifer proxy for Pinus longaeva at utah". One would not generate such a warning when using the same equation for small Pseudotsuga menziesii. -
[x] I noted that some
ref_iddiffer from the convention that we we were planning to follow (e.g., means_22_NA, whereas convention is [last name of first author_publication year_first letter of first four words in title]). What are these intended to capture? My guess may be a particular equation within a publication, in which case implementing my suggestion 2 in the top comment (add a field to equations tableoriginal_equation_id) would allow you to specify the equation number within a publication while describing the source according to the convention we had planned.
maurolepore
Non-urgent question for @gonzalezeb - Can we move equation_taxa be in the equations table? I recognize that its handy to have in sitespecies, but its also necessary to interpret the equations table, and its a property of the equation.