ropensci / babette

babette is an R package to work with BEAST2
https://docs.ropensci.org/babette
GNU General Public License v3.0
44 stars 6 forks source link

Verify RLN + tipdates works #99

Closed richelbilderbeek closed 4 months ago

richelbilderbeek commented 3 years ago

Describe the bug

There is a bug report at #90 that actually described two separate ones.

To Reproduce

This is the first one:

inference_model <- create_inference_model(
  tipdates_filename = tipdates_filename,
  clock_model = create_rln_clock_model()
)

Expected behavior

Should work, may already do so.

richelbilderbeek commented 3 years ago

I found this in the babette test suite:

test_that("use", {
  if (!is_beast2_installed()) return()
  inference_model <- create_test_inference_model(
    clock_model = create_rln_clock_model(),
    tipdates_filename = beautier::get_beautier_path(
      "test_output_0_tipdates.tsv"
    ),
    beauti_options = create_beauti_options_v2_6()
  )
  beast2_options <- create_beast2_options()
  bbt_run_from_model(
    fasta_filename = get_fasta_filename(),
    inference_model = inference_model,
    beast2_options = beast2_options
  )
  bbt_delete_temp_files(
    inference_model = inference_model,
    beast2_options = beast2_options
  )
})

So, it works!

richelbilderbeek commented 11 months ago

Regression detected by #106

richelbilderbeek commented 4 months ago

Fixed!