search

ropensci / beautier

R package to generate the same BEAST2 XML parameter files as generated by BEAUti 2
https://docs.ropensci.org/beautier
GNU General Public License v3.0
13 stars 2 forks source link

Refactor clock_models_to_xml to avoid duplication #55

Closed richelbilderbeek closed 6 years ago

richelbilderbeek commented 6 years ago

Feedback bjoelle:

all the functions clock_models_to_xml start by calling get_unlinked_clock_models. This call could be placed earlier (create_beast2_input_run is my suggestion) which would save the repetition.

richelbilderbeek commented 6 years ago

bjoelle has spotted this well.

But it must be there: the tests of clock_models_to_xml_* now test a naturally sized chunk of XML.

To keep the modularity of the clock_models_to_xml_* functions, I will keep the duplications.