ropensci / bib2df

Parse a BibTeX file to a tibble

https://docs.ropensci.org/bib2df

99 stars 22 forks source link

Close #22. Also, made some addtional improvements to df2bib() #23

Closed pegeler closed 6 years ago

pegeler commented 6 years ago

Hello,

I noticed that #22 was an easy win, so I made the change in the documentation for that.

While I was looking at the code, I noticed a few opportunities for extending the function, which I also implemented:

The user now has the option to write to stdout.
The user can now feed a tibble wherein there is a mix of data.frames and character vectors in the AUTHORS column. This might arise when the user is binding multiple tibbles together (hey, it could happen!!!).

I also took the liberty of updating the URLs to match the transition into the ropensci/bib2df repository, as well as naming myself as a contributor.

Hope that these changes meet with your approval!

Thanks,

Paul

ottlngr commented 6 years ago

Thanks for your work and the improvements on bib2df! Just noticed that some unit tests fail, probably because I moved my webspace. I'll try to fix that and will host these .bib files as gists. Then I will thankfully merge your PR!

pegeler commented 6 years ago

Hi @ottlngr!

Thanks for the great package and thanks for the feedback!

I just saw the unit test issue and fixed it. I also updated the .Rd file, which I forgot to do in my original commit!

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a7d71aa). Click here to learn what that means. The diff coverage is 40%.

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   88.18%           
=========================================
  Files             ?        6           
  Lines             ?      220           
  Branches          ?        0           
=========================================
  Hits              ?      194           
  Misses            ?       26           
  Partials          ?        0

Impacted Files	Coverage Δ
R/df2bib.R	`78.94% <40%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7d71aa...a41d82f. Read the comment docs.