search

ropensci / bib2df

Parse a BibTeX file to a tibble
https://docs.ropensci.org/bib2df
99 stars 22 forks source link

Issue#32 #34

Closed benjaminschwetz closed 4 years ago

benjaminschwetz commented 4 years ago

What I actually meant to do... replace the regex for the categories to handle lack of spaces.

ottlngr commented 4 years ago

Hi, thanks for the issue and the pull request. Are you familiar with testthat? If so, I would appreciate you to add a test case that covers reading .bib files of the kind you had trouble with.

benjaminschwetz commented 4 years ago

sure. will do

codecov-io commented 4 years ago

Codecov Report

Merging #34 into master will decrease coverage by 0.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   66.82%   66.45%   -0.37%     
==========================================
  Files           6        6              
  Lines         205      161      -44     
==========================================
- Hits          137      107      -30     
+ Misses         68       54      -14
Impacted Files Coverage Δ
R/bib2df_gather.R 94.36% <100%> (-1.68%) :arrow_down:
R/df2bib.R 9.52% <0%> (+2.11%) :arrow_up:
R/bib2df.R 69.23% <0%> (+9.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8f9486...491f0ec. Read the comment docs.

ottlngr commented 4 years ago

Thanks for your contribution. I merged your changes into the v1.1.2 branch. I'm planning to fix some other issues in this branch and will merge back into master soon.

ottlngr commented 4 years ago

Hi @benjaminschwetz ,

sorry for the delay. Yesterday I merged your changes into master. The test cases you added run successfully, so I'm going to close this issue.