Closed dieghernan closed 2 years ago
I added some comments on the review tab to make easier to understand some things @coatless
Thanks for this useful review. I would set this as a Draft until I tackle all your comments
Hi @coatless , I think I tackled all your comments, ready for review
Hi @coatless , just a quick reminder on this
:wave: @coatless @dieghernan, what's the status on this? Thanks both for your work on {bibtex} :pray:
Hi @maelle
I re-runned checks, examples and snapshots after 8 months and I see no problems, so this is ready on my side. This PR would close #16 and close #42
Thanks @dieghernan! @coatless would you be able to review this PR?
@dieghernan thanks for addressing the remaining issues. Sorry this sat for so long!
Hi:
Following #46 and related to #45 , this PR removes the C code of the package, substituting it by pure R (base) code. I am aware this is a critical change to the package, so let me share some points of attention on this PR:
trimws
has been updated to the latest version of the same function on R, see https://github.com/wch/r-source/blob/5ab79ec84040684c74dc9c901fde944fff6e8375/src/library/base/R/strwrap.R#L219-L229src
indo_read_bib()
is not needed any moreread.bib()
:header
andfooter
. They were never actually used, see: https://github.com/ropensci/bibtex/blob/05a401cda1d4f1757a82979d181c4486a54755b1/R/bibtex.R#L162-L170utils.R
. This is actually the replacement of C in R code.urlcheck
package.