search

ropensci / bibtex

bibtex parser for R
https://docs.ropensci.org/bibtex/
35 stars 12 forks source link

Replace as.personList(authors) with do.call(c, authors) #51

Closed coatless closed 1 year ago

coatless commented 1 year ago

From Kurt:

Apparently your package code still uses as.personList():

bibtex/R/bibtex.R: as.personList(authors)

Since R 2.14.0, person objects can be combined into person objects via c(), and there is no need for a seperate personList class for collections of persons.

Can you please change your code to no longer use as.personList()?

As far as we can tell, in your case 'authors' is built as a list of person objects, so you should be able to simply replace

as.personList(authors)

by

do.call(c, authors)