search

ropensci / bikedata

:bike: Extract data from public hire bicycle systems
https://docs.ropensci.org/bikedata
81 stars 16 forks source link

Can't use store_bikedata without specifying a city #48

Closed MathieuMarauri closed 6 years ago

MathieuMarauri commented 6 years ago

Hello,

I am trying out your package and I wanted to download and store the data for every cities in a database outside the temporary directory to be able to play the data without having the redownloading it each time.

I use the following code 

bike_dt <- file.path('data/database', 'bikedata.sqlite')
store_bikedata(bikedb = bike_dt)
# enter 'yes' in the console

But this fails with the error Error in store_bikedata(bikedb = bike_dt) : argument "city" is missing, with no default. If I take this line out of the function source code and retry I have this error: Error in store_bikedata(bikedb = bike_dt) : argument "city" is missing, with no default.

This package ooks nice and I am looking forward looking into the data.

Thanks for your help,

Mathieu

mpadge commented 6 years ago

thanks @MathieuMarauri. I had disabled that option because I thought it was potentially dangerous if people just typed one line and inadvertently started a 50-100GB download. I then put the text warning and question prompt in, but forgot to re-enable actually doing it. Should now work.

MathieuMarauri commented 6 years ago

Thank you very much for the quick answer.

Have a good day.